New Storage Write API REDO #2438
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tzemanovic
force-pushed
the
brent/new-storage-write-REDO
branch
from
7076f81
to
f56e9f0
Compare
tzemanovic
approved these changes
Jan 25, 2024
tzemanovic
added a commit
that referenced
this pull request
Jan 25, 2024
* brent/new-storage-write-REDO: changelog: add #2438 fix spelling of `merkelized` edit comments handle non-merklized values in `State` methods fix imports fix ibc storage init abstract instances of `write_bytes` to `write` tests bypass merklization and amend diff writing for specified keys use consts instead of string literals ibc: storage keys refactor merkle tree filter
Closed
tzemanovic
added a commit
that referenced
this pull request
Jan 25, 2024
* brent/new-storage-write-REDO: changelog: add #2438 fix spelling of `merkelized` edit comments handle non-merklized values in `State` methods fix imports fix ibc storage init abstract instances of `write_bytes` to `write` tests bypass merklization and amend diff writing for specified keys use consts instead of string literals ibc: storage keys refactor merkle tree filter
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
An alternate implementation of #2355.
With the new changes, if a key is not merklized, then it also may not be persisted in the diffs. There is no longer an either/or option.
Indicate on which release or other PRs this topic is based on
v0.30.1
Checklist before merging to
draft